Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Rails 7.1 from the installer in the CI #5421

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Exclude Rails 7.1 from the installer in the CI #5421

merged 1 commit into from
Oct 6, 2023

Conversation

elia
Copy link
Member

@elia elia commented Oct 5, 2023

Summary

Prevent the installer from using Rails 7.1, ref: #5420.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Oct 5, 2023
@elia elia requested a review from a team as a code owner October 5, 2023 20:31
@elia elia marked this pull request as draft October 5, 2023 20:31
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Oct 5, 2023
Rails 7.1 is not yet supported, until then we should not attempt
installing Solidus with it.
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #5421 (a65a742) into main (abeca54) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5421   +/-   ##
=======================================
  Coverage   88.86%   88.86%           
=======================================
  Files         607      607           
  Lines       14747    14747           
=======================================
  Hits        13105    13105           
  Misses       1642     1642           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia marked this pull request as ready for review October 5, 2023 20:57
@elia elia requested a review from rainerdema October 5, 2023 20:57
@elia elia merged commit 2abc7d3 into main Oct 6, 2023
4 checks passed
@elia elia deleted the elia/ci-7-1 branch October 6, 2023 08:51
@elia elia mentioned this pull request Oct 6, 2023
3 tasks
@elia elia added the backport-v4.2 Backport this pull-request to v4.2 label Oct 6, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

💚 All backports created successfully

Status Branch Result
v4.2

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.2 Backport this pull-request to v4.2 changelog:repository Changes to the repository not within any gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants