Use bundler gem tasks instead of gem_release #5413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elia
added
backport-v3.2
changelog:skip
github-actions
bot
added
changelog:solidus_api
Codecov Report
@@ Coverage Diff @@
## main #5413 +/- ##
=======================================
Coverage 88.86% 88.86%
=======================================
Files 607 607
Lines 14747 14747
=======================================
Hits 13105 13105
Misses 1642 1642 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kennyadsl
reviewed
Oct 4, 2023
| end | ||
| end | ||
|
|
||
| desc "Release all gems to rubygems" |
There was a problem hiding this comment.
I was under the impression that all of this code was not used at all by gem-release. Instead, this was the previous system used to release (see #83). I think the subgems release was managed by the recurse option set in the gem-release config.
That said, I'm in favor of removing the dependency and simplifying the process but I have two concerns:
- I suspect with the proposed changes we are not releasing the main
solidusgem but only the subgems. - Having two different ways of releasing for new/older versions might create complications. Is there a way to uniform the two? Both having the same interface or backporting is ok for me, but if you have other ideas, they are welcome.
There was a problem hiding this comment.
Thanks, yes the recurse option is what got in the way with solidus_admin.
- Good catch! Fixed 👍
- Added back ports labels for all supported versions
Now that we also have a solidus_admin that follows a different release track we need more control over what gems are released. `gem_release` has no such control available and simply has a configuration for recursing. Also all the features of `gem_relerase` regarding version numbers manipulation are no longer relevant as it all happens within GitHub actions using dev_tools. Bundler gem tasks are now the standard for all our extensions and are a simpler, already available, tool that can be leveraged here as well.
elia
force-pushed
the
elia/gem-releasing
branch
from
63fc31e to
ccf0eaa
Compare
rainerdema
approved these changes
Oct 4, 2023
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that we also have a solidus_admin that follows a different release track we need more control over what gems are released.
gem_releasehas no such control available and simply has a configuration for recursing. Also all the features ofgem_releraseregarding version numbers manipulation are no longer relevant as it all happens within GitHub actions using dev_tools.Bundler gem tasks are now the standard for all our extensions and are a simpler, already available, tool that can be leveraged here as well.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: