Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin] make SolidusAdmin opt-in while installing solidus #5400

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

elia
Copy link
Member

@elia elia commented Sep 29, 2023

Summary

Ensure SolidusAdmin is really opt-in during the installation.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Sep 29, 2023
@github-actions github-actions bot added changelog:solidus_core Changes to the solidus_core gem changelog:repository Changes to the repository not within any gem labels Sep 29, 2023
@elia elia force-pushed the elia/admin/make-it-opt-in branch from c39e65c to a5372d3 Compare September 29, 2023 11:23
@elia elia marked this pull request as ready for review September 29, 2023 11:33
@elia elia requested a review from a team as a code owner September 29, 2023 11:33
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #5400 (a5372d3) into nebulab/admin (1288f9c) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           nebulab/admin    #5400   +/-   ##
==============================================
  Coverage          88.77%   88.77%           
==============================================
  Files                609      609           
  Lines              14762    14762           
==============================================
  Hits               13105    13105           
  Misses              1657     1657           
Files Coverage Δ
...ib/generators/solidus/install/install_generator.rb 49.63% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia requested review from rainerdema and removed request for a team September 29, 2023 11:35
@elia elia merged commit eb1c18e into nebulab/admin Sep 29, 2023
@elia elia deleted the elia/admin/make-it-opt-in branch September 29, 2023 11:35
@elia elia removed the request for review from rainerdema September 29, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:repository Changes to the repository not within any gem changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants