Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest bundle when testing solidus installation #5396

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

elia
Copy link
Member

@elia elia commented Sep 29, 2023

Summary

Whenever the gem or bundler versions change we should bust the cache key.
Also reach for the latest bundler version and get bug fixes and performance gains.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia requested a review from rainerdema September 29, 2023 08:04
@elia elia self-assigned this Sep 29, 2023
@elia elia requested a review from a team as a code owner September 29, 2023 08:04
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #5396 (ecdd51a) into main (e4ae444) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5396   +/-   ##
=======================================
  Coverage   88.74%   88.74%           
=======================================
  Files         565      565           
  Lines       13986    13986           
=======================================
  Hits        12412    12412           
  Misses       1574     1574           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia added this to the 4.2 milestone Sep 29, 2023
@elia elia merged commit 803be9d into main Sep 29, 2023
4 checks passed
@elia elia deleted the elia/ci-cache-keys branch September 29, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:repository Changes to the repository not within any gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants