Update the Spree::Backend navigation menu to match the upcoming SolidusAdmin
#5392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:solidus_backend
elia
force-pushed
the
elia/admin-support
branch
from
210449e to
e73d2a3
Compare
github-actions
bot
added
changelog:solidus
elia
force-pushed
the
elia/admin-support
branch
from
e73d2a3 to
a08b606
Compare
elia
force-pushed
the
elia/admin-support
branch
from
a08b606 to
335bd5f
Compare
Codecov Report
@@ Coverage Diff @@
## main #5392 +/- ##
=======================================
Coverage 88.76% 88.77%
=======================================
Files 564 564
Lines 13960 13972 +12
=======================================
+ Hits 12392 12404 +12
Misses 1568 1568
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
github-actions
bot
added
the
changelog:repository
elia
force-pushed
the
elia/admin-support
branch
2 times, most recently
from
c15ac78 to
c445c25
Compare
elia
force-pushed
the
elia/admin-support
branch
from
c445c25 to
665d974
Compare
elia
changed the title
SolidusAdmin
elia
changed the title
SolidusAdminSpree::backend navigation menu to match the upcoming SolidusAdmin`
elia
changed the title
Spree::backend navigation menu to match the upcoming SolidusAdmin`Spree::Backend navigation menu to match the upcoming SolidusAdmin
This wasn't available back when the CSS was initially created, but it's a far superior value than 100%.
Replace the currently hardcoded one with a proper reference.
This will allow using them even if the theme is not selected.
As the cookie was set relative to the path where the switcher was clicked, it created as many cookies as paths where the switcher was clicked. That was causing the switcher to not work when a previous cookie was also encompassing the current path. To reproduce (in Chrome): 1. Initiate the sandbox application (new admin is on by default) 2. Go to the product creation page. It falls back to the legacy admin but the switcher is still on the new admin. 3. Click on the switcher to go back to the legacy admin. It works. The cookie is set for `/admin/products` to `false`. 4. Go to the product listing. Switch again to the new admin. It sets the cookie for `/admin` to `true`, but as the `/admin/products` cookie also applies and takes precedence, the new route is not taken into account.
Now defaults to the english translation that we know to be present, previously it was rendering HTML within an attribute, thus breaking the page.
Fix the sidebar menu stickyness at different window heights.
`link_tree` seems to be failing when the server is restarted. Given we're just providing two themes we can list them individually.
elia
force-pushed
the
elia/admin-support
branch
from
665d974 to
38cd7b0
Compare
rainerdema
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These (except the last 5) are commits extracted from the
nebulab/adminbranch and kept untouched except for changes applying to theadmin/directory. This is done to minimize conflicts whennebulab/adminwill be eventually rebased on them.The last 5 commits are further adjustments and backports on top of the same branch that were either missing or which commits didn't make sense outside of the branch.
Contents
This PR basically takes care of two things:
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: