Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hm 02 products privacy #5389

Closed

Conversation

AbubakarBhatti2022
Copy link

Summary

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@AbubakarBhatti2022 AbubakarBhatti2022 requested a review from a team as a code owner September 20, 2023 07:23
@github-actions github-actions bot added changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem labels Sep 20, 2023
@tvdeyen
Copy link
Member

tvdeyen commented Sep 20, 2023

@AbubakarBhatti2022 this is most likely a mistake? Please make sure to open PR against your fork and not this repo. Thanks

@tvdeyen tvdeyen closed this Sep 20, 2023
@jarednorman
Copy link
Member

@AbubakarBhatti2022 This is the third time you've made an erroneous PR like this against a Solidus repository. I assume that these were simply made by mistake, but if you continue to spam our repositories with PRs like this I'll be forced to block you from the Solidus organization.

I believe I commented this on a previous PR, but I also strongly recommend you go spend some time with the Solidus developer documentation, especially the sections on customization. It appears that you're customizing the Solidus gem directly. I strongly advise against this as it will certainly cause issues for you in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants