Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[admin] Add the danger scheme to the ui/button component #5384

Merged
merged 2 commits into from
Sep 15, 2023
Merged

[admin] Add the danger scheme to the ui/button component #5384

merged 2 commits into from
Sep 15, 2023

Conversation

elia
Copy link
Member

@elia elia commented Sep 15, 2023 •
edited
Loading

Summary

image

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Sep 15, 2023
@github-actions github-actions bot added changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus Changes to the solidus meta-gem changelog:repository Changes to the repository not within any gem changelog:solidus_admin labels Sep 15, 2023
@elia elia changed the base branch from main to nebulab/admin September 15, 2023 08:42
@elia elia requested a review from rainerdema September 15, 2023 08:43
@codecov
Copy link

codecov bot commented Sep 15, 2023 •
edited
Loading

Codecov Report

Merging #5384 (9a26bf9) into nebulab/admin (ffe49be) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           nebulab/admin    #5384   +/-   ##
==============================================
  Coverage          88.86%   88.86%           
==============================================
  Files                615      615           
  Lines              14860    14860           
==============================================
  Hits               13205    13205           
  Misses              1655     1655
Files Changed Coverage Δ
...pp/components/solidus_admin/ui/button/component.rb 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia removed changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus Changes to the solidus meta-gem changelog:repository Changes to the repository not within any gem labels Sep 15, 2023
@elia elia marked this pull request as ready for review September 15, 2023 08:55
@elia elia requested a review from a team as a code owner September 15, 2023 08:55
elia added 2 commits September 15, 2023 11:07
@elia
Fix the ui/button component focus and disabled styles
b20ae32 
The focus ring was not properly shown and the disabled border wasn't set.
@elia
Add the danger scheme to the ui/button component
9a26bf9
@elia elia force-pushed the elia/admin/danger-button branch from a1bb86e to 9a26bf9 Compare September 15, 2023 09:08
rainerdema
rainerdema approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@rainerdema rainerdema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@elia elia merged commit 74dcc5f into nebulab/admin Sep 15, 2023
4 checks passed
@elia elia deleted the elia/admin/danger-button branch September 15, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainerdema rainerdema rainerdema approved these changes

Assignees

@elia elia

Labels
changelog:solidus_admin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elia @rainerdema