Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cilean Spanish language support for Select2 plugin #5377

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

MauricioTRP
Copy link
Contributor

Added missing select2_local es-CL

Summary

Added missing file select2_locale_es-CL language in order to use es-CL locales with I18n

@MauricioTRP MauricioTRP requested a review from a team as a code owner September 11, 2023 17:56
@github-actions github-actions bot added the changelog:solidus_backend Changes to the solidus_backend gem label Sep 11, 2023
Added missing select2_local es-CL
@elia elia force-pushed the fix/es-CL_select2_localJS branch from 3f3b1f4 to 28ae3e2 Compare September 25, 2023 15:48
@elia elia self-assigned this Sep 25, 2023
Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MauricioTRP thanks for your contribution!

Looks like the CI errors are coming from somewhere else, I rebased and added an EOF newline.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #5377 (28ae3e2) into main (1891495) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5377   +/-   ##
=======================================
  Coverage   88.76%   88.76%           
=======================================
  Files         564      564           
  Lines       13959    13959           
=======================================
  Hits        12391    12391           
  Misses       1568     1568           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia merged commit b00ae25 into solidusio:main Sep 25, 2023
4 checks passed
@MauricioTRP
Copy link
Contributor Author

Thank you @elia!
I didn't knew how to make pass that CI test.

It's a pleasure to help

@elia elia changed the title Added es-CL select2_locale js Added support for es-CL (Cilean spanish) to select2 Sep 26, 2023
@elia elia changed the title Added support for es-CL (Cilean spanish) to select2 Add Cilean Spanish language support for Select2 plugin Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants