[Admin] Add a ui/panel component
#5371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## nebulab/admin #5371 +/- ##
==============================================
Coverage 88.00% 88.01%
==============================================
Files 613 614 +1
Lines 14892 14897 +5
==============================================
+ Hits 13106 13111 +5
Misses 1786 1786
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
elia
force-pushed
the
elia/admin/ui-panel
branch
2 times, most recently
from
32c1ce6 to
e62130d
Compare
the-krg
approved these changes
Sep 8, 2023
| def initialize(title: nil, title_hint: nil, actions: nil) | ||
| @title = title | ||
| @title_hint = title_hint | ||
| @actions = actions |
There was a problem hiding this comment.
Recently I've discovered that ViewComponent allows us to add new slots to the blocks we open when creating a component.
What do you think on turning the actions section into a slot? (Just like the content) So the dev can have more freedom instead of just passing the HTML on the initializer.
https://viewcomponent.org/guide/slots.html
like
has_one :actions
and
<%= render current_component.new(title: "SEO", title_hint: "Search Engine Optimization") do |panel| %>
<label>
SKU:
ABC-123
</label>
<% panel.with_actions do %>
...HTML
<% end %>
<% end %>
There was a problem hiding this comment.
Thanks great call! I'll embed this change in the products#show PR and update this later on 👍👍👍
elia
force-pushed
the
elia/admin/ui-panel
branch
2 times, most recently
from
9da2d1e to
37cedc1
Compare
elia
force-pushed
the
elia/admin/ui-panel
branch
from
37cedc1 to
0b45920
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: