Fix offense after RuboCop 1.56 #5318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubocop 1.56 fixed a false negative for `Style/RedundantReturn` cop. See rubocop/rubocop#12106
github-actions
bot
added
the
changelog:solidus_core
3 tasks
elia
approved these changes
Aug 9, 2023
waiting-for-dev
deleted the
waiting-for-dev/fix_offense_after_rubocop_1.56
branch
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
elia
added
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rubocop 1.56 fixed a false negative for
Style/RedundantReturncop.See rubocop/rubocop#12106
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: