Deprecate the Spree::Adjustment.return_authorization scope
#5138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
Codecov Report
@@ Coverage Diff @@
## main #5138 +/- ##
=======================================
Coverage 88.76% 88.76%
=======================================
Files 564 564
Lines 13959 13960 +1
=======================================
+ Hits 12391 12392 +1
Misses 1568 1568
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jarednorman
reviewed
Jun 12, 2023
|
I have not found a single usage in Solidus since v1.0. I've checked in the Spree repo as well, where I could not find usages of this either. |
|
Thanks! Given the minimal effort, it won't hurt to add a deprecation message. It wouldn't be unexpected to find something unexpected in some stores 🙂 |
There is no code path that creates adjustments from return authorizations (since a long time). This line was introduced without a lot of context in 2013, and there is nothing in the current codebase that warrants this scope.
elia
force-pushed
the
remove-adjustment-return-authorizations-scope
branch
from
5146714 to
60b4916
Compare
elia
changed the title
Spree::Adjustment.return_authorization scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is no code path that creates adjustments from return authorizations (since a long time).
This line was introduced without a lot of context in 2013, and there is nothing in the current codebase that warrants this scope.
I don't think adding a deprecation notice will do anything for anyone. If anyone tells me this scope currently returns a record in their stores, I'll add one. :)
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed:
I have updated the README to account for my changes.I have documented new code with YARD.I have opened a PR to update the guides.I have added automated tests to cover my changes.I have attached screenshots to demo visual changes.