Deprecate Paperclip Adapter #5100
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
|
|
||
| class_option :app_name, | ||
| type: :string, | ||
| default: 'MyStore', |
There was a problem hiding this comment.
I think we can automate that with Rails.application.class.module_parent.name
There was a problem hiding this comment.
It was on my metal TODO list, and of course, I forgot about it. Thanks!
At the moment, the paperclip CI jobs should use the old adapter, which I don't think it's working because tests are failing and I don't understand why. Your proposed approach seems interesting, this way we'll stop using the deprecated adapter and just rely on the generated files. I'll give it a try. |
kennyadsl
force-pushed
the
kennyadsl/paperclip-adapter-deprecation
branch
2 times, most recently
from
a27f81a to
995172c
Compare
kennyadsl
force-pushed
the
kennyadsl/paperclip-adapter-deprecation
branch
2 times, most recently
from
3f18496 to
87bc6c3
Compare
This generator allows incorporating the paperclip adapter into the host application, in order to remove support for it from core. This generator does two things: 1. Copy the Image and Taxon Paperclip adapters into the host application; 2. Set the right configurations in the spree.rb (path configurable) initializer in order to use the newly created files.
We are also providing a message with instructions for who wants to keep using Paperclip. We are silencing deprecation warnings when setting the deprecated configuration in the CI. This will allow us to keep testing if our code still works with the deprecated adapter.
When `--active_storage=false` is used in for the main installer we can use the new generator to copy the adapter in the host application.
Only when we are testing against Paperclip in the build matrix.
kennyadsl
force-pushed
the
kennyadsl/paperclip-adapter-deprecation
branch
from
87bc6c3 to
7442e93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #5033
Add
solidus:paperclip_adapter:installgenerator, which allows incorporating the paperclip adapter into the host application, in order to remove support for it from the core.This generator does two things:
This PR also deprecates the Paperclip adapters, so that we can remove it in the next major version.
TODOs
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: