Expose ...OrderAdjustmentsRecalculator#calculate_eligibility bug

[julienanne]

Summary

Spec to expose the inaccurate adjustment eligibility with shipping promotion action during Spree::Promotion::OrderAdjustmentsRecalculator call
The issue #2387 expose many different way to have the trouble and to correct them temporary but not definitively ;)
Sorry but can't, at the moment, propose a correction PR just a failing spec to expose the trouble for inspiration.
I make it draft for the moment.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

• I have written a thorough PR description.
• I have kept my commits small and atomic.
• I have used clear, explanatory commit messages.

The following are not always needed:

• 📖 I have updated the README to account for my changes.
• 📑 I have documented new code with YARD.
• 🛣️ I have opened a PR to update the guides.
• ✅ I have added automated tests to cover my changes.
• 📸 I have attached screenshots to demo visual changes.

[waiting-for-dev]

Thanks, @julienanne. Marking it as a draft for now.

[fthobe]

@mamhoff this is solved with the new promotion system, right?

[mamhoff]

Yes, this shouldn't happen with the new promo system. If you want to be super-sure, you can port the test to solidus_promotions and see for yourself.

[fthobe]

@jarednorman can in fact be closed as resolved

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.33%. Comparing base (6d55800) to head (254b9c6).
Report is 2430 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4965      +/-   ##
==========================================
+ Coverage   86.69%   92.33%   +5.64%     
==========================================
  Files         578      123     -455     
  Lines       14681     3354   -11327     
==========================================
- Hits        12728     3097    -9631     
+ Misses       1953      257    -1696     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.