Merge pull request #5812 from MadelineCollier/lock-ransack-version

Lock solidus_core.gemspec to ransack '< 4.2'
solidusio · Aug 8, 2024 · b3111b2 · b3111b2
2 parents f2a32d6 + 1664d10
commit b3111b2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/...n/spec/components/previews/solidus_admin/ui/thumbnail/component_preview/overview.html.erb b/...n/spec/components/previews/solidus_admin/ui/thumbnail/component_preview/overview.html.erb
@@ -50,7 +50,7 @@
 <div class="flex gap-4">
   <% product = Spree::Product.new(name: "A good product") %>
   <% attachment = Object.new.tap { def _1.url(*) "https://placekitten.com/280/200"; end }  %>
-  <% image = Spree::Image.new.tap { _1.define_singleton_method(:attachment) { attachment } } %>
+  <% image = Spree::Image.new.tap { |img| img.define_singleton_method(:attachment) { attachment } } %>
   <% [
     Spree::UnitCancel.new,
     Spree::TaxRate.new,

diff --git a/core/solidus_core.gemspec b/core/solidus_core.gemspec
@@ -43,7 +43,9 @@ Gem::Specification.new do |s|
   s.add_dependency 'monetize', '~> 1.8'
   s.add_dependency 'kt-paperclip', ['>= 6.3', '< 8']
   s.add_dependency 'psych', ['>= 4.0.1', '< 6.0']
-  s.add_dependency 'ransack', '~> 4.0'
+  # @note ransack 4.2 contains a bug which has not yet been addressed.
+  # @see https://github.com/activerecord-hackery/ransack/pull/1468
+  s.add_dependency 'ransack', ['~> 4.0', '< 4.2']
   s.add_dependency 'sprockets-rails', '!= 3.5.0'
   s.add_dependency 'state_machines-activerecord', '~> 0.6'
   s.add_dependency 'omnes', '~> 0.2.2'