Merge pull request #5998 from MadelineCollier/fix/flaky-modal-specs

[specs] Wait for modal before testing its content
solidusio · Dec 4, 2024 · 81c605c · 81c605c
2 parents e2f5282 + a25a62a
commit 81c605c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/admin/spec/features/refund_reasons_spec.rb b/admin/spec/features/refund_reasons_spec.rb
@@ -26,7 +26,7 @@
     before do
       visit "/admin/refund_reasons/#{query}"
       click_on "Add new"
-      expect(page).to have_selector("dialog")
+      expect(page).to have_css("dialog", wait: 5)
       expect(page).to have_content("New Refund Reason")
       expect(page).to be_axe_clean
     end
@@ -66,7 +66,7 @@
       Spree::RefundReason.create(name: "Return process")
       visit "/admin/refund_reasons#{query}"
       find_row("Return process").click
-      expect(page).to have_selector("dialog")
+      expect(page).to have_css("dialog", wait: 5)
       expect(page).to have_content("Edit Refund Reason")
       expect(page).to be_axe_clean
     end

diff --git a/admin/spec/features/shipping_categories_spec.rb b/admin/spec/features/shipping_categories_spec.rb
@@ -26,7 +26,7 @@
     before do
       visit "/admin/shipping_categories#{query}"
       click_on "Add new"
-      expect(page).to have_selector("dialog")
+      expect(page).to have_css("dialog", wait: 5)
       expect(page).to have_content("New Shipping Category")
       expect(page).to be_axe_clean
     end
@@ -66,7 +66,7 @@
       Spree::ShippingCategory.create(name: "Letter Mail")
       visit "/admin/shipping_categories#{query}"
       find_row("Letter Mail").click
-      expect(page).to have_selector("dialog")
+      expect(page).to have_css("dialog", wait: 5)
       expect(page).to have_content("Edit Shipping Category")
       expect(page).to be_axe_clean
     end