Skip to content

Commit

Permalink
Merge pull request #6018 from solidusio/backport/v4.4/pr-6017
Browse files Browse the repository at this point in the history
[v4.4] tests: Give even more dialogs more time to open in tests
  • Loading branch information
tvdeyen authored Dec 6, 2024
2 parents bfdf4bb + 6c75834 commit 6181ee3
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 13 deletions.
4 changes: 2 additions & 2 deletions admin/spec/features/adjustment_reasons_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down Expand Up @@ -76,7 +76,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down
4 changes: 2 additions & 2 deletions admin/spec/features/refund_reasons_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down Expand Up @@ -73,7 +73,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down
4 changes: 2 additions & 2 deletions admin/spec/features/return_reasons_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down Expand Up @@ -75,7 +75,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down
4 changes: 2 additions & 2 deletions admin/spec/features/roles_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down Expand Up @@ -130,7 +130,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down
4 changes: 2 additions & 2 deletions admin/spec/features/shipping_categories_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down Expand Up @@ -73,7 +73,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down
4 changes: 2 additions & 2 deletions admin/spec/features/store_credit_reasons_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down Expand Up @@ -73,7 +73,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down
2 changes: 1 addition & 1 deletion admin/spec/features/tax_categories_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down

0 comments on commit 6181ee3

Please sign in to comment.