Skip to content

Commit

Permalink
Hints update
Browse files Browse the repository at this point in the history
Hints that display in tooltip have to be clear and concise. Fields that
might have a critical effect to product creation are always visible
under the field. Hints that don't give relevant suggestions, have been
removed.
  • Loading branch information
mfrecchiami committed Oct 16, 2023
1 parent 33e539d commit 590a7ac
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
<%= render component("ui/forms/field").text_area(f, :description) %>
<% end %>

<%= render component('ui/panel').new(title: 'SEO', title_hint: 'Search Engine Optimization') do %>
<%= render component('ui/panel').new(title: 'SEO') do %>
<%= render component("ui/forms/field").text_field(f, :meta_title) %>
<%= render component("ui/forms/field").text_field(f, :meta_description) %>
<%= render component("ui/forms/field").text_area(f, :meta_keywords) %>
Expand Down Expand Up @@ -109,8 +109,8 @@

<aside class="justify-center items-start gap-4 flex flex-col w-full max-w-sm">
<%= render component('ui/panel').new(title: "Publishing") do %>
<%= render component("ui/forms/field").text_field(f, :available_on, tip: t(".hints.available_on_html"), type: :date) %>
<%= render component("ui/forms/field").text_field(f, :discontinue_on, tip: t(".hints.discontinue_on_html"), type: :date) %>
<%= render component("ui/forms/field").text_field(f, :available_on, hint: t(".available_on_html"), type: :date) %>
<%= render component("ui/forms/field").text_field(f, :discontinue_on, hint: t(".discontinue_on_html"), type: :date) %>

<label class="flex gap-2 items-center">
<%= render component("ui/forms/checkbox").new(
Expand Down
10 changes: 5 additions & 5 deletions admin/app/components/solidus_admin/products/show/component.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ en:
manage_properties: "Manage product specifications"
manage_stock: "Manage stock"
delete_confirmation: "Are you sure you want to delete this product?"
available_on_html: 'Product availability starts from the set date.<br> Empty date indicates no availability.'
discontinue_on_html: 'Product availability ends from the set date.<br> Empty date indicates continuous availability.'
hints:
available_on_html: This sets the availability date for the product. If this value is not set, or it is set to a date in the future, then the product is not available on the storefront.
discontinue_on_html: This sets the discontinue date for the product. If this value is set to a date, then the product is not available on the storefront from that day on anymore.
promotionable_html: 'This determines whether or not promotions can apply to this product.<br>Default: Checked'
shipping_category_html: 'This determines what kind of shipping this product requires.<br> Default: Default'
tax_category_html: 'This determines what kind of taxation is applied to this product.<br> Default: %{default_tax_category}'
promotionable_html: Promotions can apply to this product
shipping_category_html: Manage Shipping in Settings
tax_category_html: Manage Taxes in Settings
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
With title and hint
</h6>

<%= render current_component.new(title: "SEO", title_hint: "Search Engine Optimization") do %>
<%= render current_component.new(title: "SEO") do %>
<label>
SKU:
ABC-123
Expand All @@ -42,7 +42,7 @@
With title, hint, and actions
</h6>

<%= render current_component.new(title: "SEO", title_hint: "Search Engine Optimization") do |panel| %>
<%= render current_component.new(title: "SEO") do |panel| %>
<label>
SKU:
ABC-123
Expand All @@ -57,7 +57,7 @@
With no content
</h6>

<%= render current_component.new(title: "SEO", title_hint: "Search Engine Optimization") do |panel| %>
<%= render current_component.new(title: "SEO") do |panel| %>
<% panel.with_action(name: "Foo", href: "#foo") %>
<% end %>
</div>

0 comments on commit 590a7ac

Please sign in to comment.