Separate store credit cases from user feature spec

This spec was becoming really long, and since store credit actions get
their own controller and their own request specs, it makes sense to
break these out into their own feature spec too. Now if one case fails
we don't have to re-run this entire enormous user spec.

admin/spec/features/store_credits_spec.rb

@@ -0,0 +1,142 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe "StoreCredits", :js, type: :feature do
+  let(:admin) { create(:admin_user, email: "[email protected]") }
+
+  before do
+    sign_in admin
+  end
+
+  context "when a user has no store credits" do
+    before do
+      create(:user, email: "[email protected]")
+      visit "/admin/users"
+      find_row("[email protected]").click
+      click_on "Store Credit"
+    end
+
+    it "shows the store credits page" do
+      expect(page).to have_content("Users / [email protected] / Store Credit")
+      expect(page).to have_content("Lifetime Stats")
+      expect(page).to have_content("Store Credit")
+      expect(page).to be_axe_clean
+    end
+
+    it "shows the appropriate content" do
+      expect(page).to have_content("No Store Credits found.")
+    end
+  end
+
+  context "when a user has store credits" do
+    let!(:store_credit) { create(:store_credit, amount: 199.00, currency: "USD") }
+    let!(:store_credit_reason) { create(:store_credit_reason, name: "credit given in error") }
+
+    before do
+      store_credit.user.update(email: "[email protected]")
+
+      visit "/admin/users"
+      find_row("[email protected]").click
+      click_on "Store Credit"
+    end
+
+    it "shows the store credits page" do
+      expect(page).to have_content("Users / [email protected] / Store Credit")
+      expect(page).to have_content("Lifetime Stats")
+      expect(page).to have_content("Store Credit")
+      expect(page).to be_axe_clean
+    end
+
+    it "lists the user's store credit" do
+      expect(page).to have_content("Current balance: $199.00")
+      expect(page).to have_content("Credited")
+      expect(page).to have_content("Authorized")
+      expect(page).to have_content("Used")
+      expect(page).to have_content("Type")
+      expect(page).to have_content("Created by")
+      expect(page).to have_content("Issued on")
+      expect(page).to have_content("Invalidated")
+      expect(page).not_to have_content("No Store Credits found.")
+    end
+
+    context "when clicking through to a single store credit" do
+      let!(:store_credit_reason) { create(:store_credit_reason, name: "credit given in error") }
+
+      before do
+        stub_authorization!(admin)
+        find_row("$199.00").click
+      end
+
+      it "shows individual store credit details" do
+        expect(page).to have_content("Users / [email protected] / Store Credit / $199.00")
+        expect(page).to have_content("Store Credit History")
+        expect(page).to have_content("Action")
+        expect(page).to have_content("Added")
+      end
+
+      it "allows invalidating of the store credit" do
+        click_on "Invalidate"
+        select "credit given in error", from: "store_credit_reason_id"
+        click_on "Invalidate"
+        expect(page).to have_content("Store Credit History")
+        expect(page).to have_content("Action")
+        expect(page).to have_content("Added")
+        expect(page).to have_content("Invalidated")
+        expect(page).to have_content("Reason for updating")
+        expect(page).to have_content("credit given in error")
+      end
+
+      context "when editing the store credit amount" do
+        context "with invalid amount" do
+          it "shows the appropriate error message" do
+            click_on "Edit Amount"
+            expect(page).to have_selector("dialog", wait: 5)
+            expect(page).to have_content("Edit Store Credit")
+
+            within("dialog") do
+              fill_in "Amount", with: ""
+              click_on "Update Store Credit"
+              expect(page).to have_content("must be greater than 0")
+              click_on "Cancel"
+            end
+          end
+        end
+
+        context "without a valid reason" do
+          it "shows the appropriate error message" do
+            click_on "Edit Amount"
+            expect(page).to have_selector("dialog", wait: 5)
+            expect(page).to have_content("Edit Store Credit")
+
+            within("dialog") do
+              fill_in "Amount", with: "100"
+              click_on "Update Store Credit"
+              expect(page).to have_content("Store Credit reason must be provided")
+              click_on "Cancel"
+            end
+          end
+        end
+
+        context "with valid params" do
+          it "allows editing of the store credit amount" do
+            click_on "Edit Amount"
+            expect(page).to have_selector("dialog", wait: 5)
+            expect(page).to have_content("Edit Store Credit")
+
+            # Invalid amount
+            within("dialog") do
+              fill_in "Amount", with: "666"
+              select "credit given in error", from: "store_credit[store_credit_reason_id]"
+              click_on "Update Store Credit"
+            end
+
+            expect(page).to have_content("Users / [email protected] / Store Credit / $666.00")
+            expect(page).to have_content("Adjustment")
+            expect(page).to have_content("credit given in error")
+          end
+        end
+      end
+    end
+  end
+end

admin/spec/features/users_spec.rb

@@ -252,137 +252,4 @@
       end
     end
   end
-
-  context "when viewing a user's store credits" do
-    context "when a user has no store credits" do
-      before do
-        create(:user, email: "[email protected]")
-        visit "/admin/users"
-        find_row("[email protected]").click
-        click_on "Store Credit"
-      end
-
-      it "shows the store credits page" do
-        expect(page).to have_content("Users / [email protected] / Store Credit")
-        expect(page).to have_content("Lifetime Stats")
-        expect(page).to have_content("Store Credit")
-        expect(page).to be_axe_clean
-      end
-
-      it "shows the appropriate content" do
-        expect(page).to have_content("No Store Credits found.")
-      end
-    end
-
-    context "when a user has store credits" do
-      let!(:store_credit) { create(:store_credit, amount: 199.00, currency: "USD") }
-      let!(:store_credit_reason) { create(:store_credit_reason, name: "credit given in error") }
-
-      before do
-        store_credit.user.update(email: "[email protected]")
-
-        visit "/admin/users"
-        find_row("[email protected]").click
-        click_on "Store Credit"
-      end
-
-      it "shows the store credits page" do
-        expect(page).to have_content("Users / [email protected] / Store Credit")
-        expect(page).to have_content("Lifetime Stats")
-        expect(page).to have_content("Store Credit")
-        expect(page).to be_axe_clean
-      end
-
-      it "lists the user's store credit" do
-        expect(page).to have_content("Current balance: $199.00")
-        expect(page).to have_content("Credited")
-        expect(page).to have_content("Authorized")
-        expect(page).to have_content("Used")
-        expect(page).to have_content("Type")
-        expect(page).to have_content("Created by")
-        expect(page).to have_content("Issued on")
-        expect(page).to have_content("Invalidated")
-        expect(page).not_to have_content("No Store Credits found.")
-      end
-
-      context "when clicking through to a single store credit" do
-        let!(:store_credit_reason) { create(:store_credit_reason, name: "credit given in error") }
-
-        before do
-          stub_authorization!(admin)
-          find_row("$199.00").click
-        end
-
-        it "shows individual store credit details" do
-          expect(page).to have_content("Users / [email protected] / Store Credit / $199.00")
-          expect(page).to have_content("Store Credit History")
-          expect(page).to have_content("Action")
-          expect(page).to have_content("Added")
-        end
-
-        it "allows invalidating of the store credit" do
-          click_on "Invalidate"
-          select "credit given in error", from: "store_credit_reason_id"
-          click_on "Invalidate"
-          expect(page).to have_content("Store Credit History")
-          expect(page).to have_content("Action")
-          expect(page).to have_content("Added")
-          expect(page).to have_content("Invalidated")
-          expect(page).to have_content("Reason for updating")
-          expect(page).to have_content("credit given in error")
-        end
-
-        context "when editing the store credit amount" do
-          context "with invalid amount" do
-            it "shows the appropriate error message" do
-              click_on "Edit Amount"
-              expect(page).to have_selector("dialog", wait: 5)
-              expect(page).to have_content("Edit Store Credit")
-
-              within("dialog") do
-                fill_in "Amount", with: ""
-                click_on "Update Store Credit"
-                expect(page).to have_content("must be greater than 0")
-                click_on "Cancel"
-              end
-            end
-          end
-
-          context "without a valid reason" do
-            it "shows the appropriate error message" do
-              click_on "Edit Amount"
-              expect(page).to have_selector("dialog", wait: 5)
-              expect(page).to have_content("Edit Store Credit")
-
-              within("dialog") do
-                fill_in "Amount", with: "100"
-                click_on "Update Store Credit"
-                expect(page).to have_content("Store Credit reason must be provided")
-                click_on "Cancel"
-              end
-            end
-          end
-
-          context "with valid params" do
-            it "allows editing of the store credit amount" do
-              click_on "Edit Amount"
-              expect(page).to have_selector("dialog", wait: 5)
-              expect(page).to have_content("Edit Store Credit")
-
-              # Invalid amount
-              within("dialog") do
-                fill_in "Amount", with: "666"
-                select "credit given in error", from: "store_credit[store_credit_reason_id]"
-                click_on "Update Store Credit"
-              end
-
-              expect(page).to have_content("Users / [email protected] / Store Credit / $666.00")
-              expect(page).to have_content("Adjustment")
-              expect(page).to have_content("credit given in error")
-            end
-          end
-        end
-      end
-    end
-  end
 end