Call empty only on incomplete orders

Code fails with a 500 on admin because of the order shipping status. The change triggers @order.empty! only when the order is incomplete. Co-authored-by: An Stewart <[email protected]>
solidusio · Aug 14, 2024 · 4a761b8 · 4a761b8
1 parent 2ae2bfd
commit 4a761b8
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/api/app/controllers/spree/api/orders_controller.rb b/api/app/controllers/spree/api/orders_controller.rb
@@ -46,7 +46,9 @@ def create
 
       def empty
         authorize! :update, @order, order_token
-        @order.empty!
+
+        @order.empty! unless @order.complete?
+
         respond_with(@order, default_template: :show)
       end