Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use devComponent in lazy for devtools support #2389

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thetarnav
Copy link
Contributor

Because lazy doesn't call the component function using JSX or createComponent it doesn't show up in the devtools properly.
This replaces the function call with devComponent if in dev mode.

Although it may be a bit odd, as devComponent is an internal-only api, and lazy should probably be fully implementable in userland, right?
Maybe there is a way to just use createComponent there, as the logic is very similar.

return createMemo(() => (Comp = comp()) ? createComponent(Comp, props) : "")

Copy link

changeset-bot bot commented Dec 27, 2024

⚠️ No Changeset found

Latest commit: 9cb0e56

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12521432658

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.3%) to 86.957%

Files with Coverage Reduction New Missed Lines %
packages/solid/src/reactive/scheduler.ts 1 80.95%
Totals Coverage Status
Change from base Build 11846786421: 1.3%
Covered Lines: 2332
Relevant Lines: 2612

💛 - Coveralls

thetarnav added a commit to thetarnav/solid-devtools that referenced this pull request Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants