Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing code block end in useTransition's jsdoc comment #2301

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Fix missing code block end in useTransition's jsdoc comment #2301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e24bc7a
Fix missing code block end in doc comment
Legend-Master Sep 22, 2024
f7200fc
Add change file
Legend-Master Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/use-transition-doc-comment.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"solid-js": patch
---

Fix missing code block end in `useTransition`'s jsdoc comment
1 change: 1 addition & 0 deletions packages/solid/src/reactive/signal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1087,6 +1087,7 @@ export type Transition = [Accessor<boolean>, (fn: () => void) => Promise<void>];
* () => boolean,
* (fn: () => void, cb?: () => void) => void
* ];
* ```
* @returns a tuple; first value is an accessor if the transition is pending and a callback to start the transition
*
* @description https://docs.solidjs.com/reference/reactive-utilities/use-transition
Expand Down
Loading