Skip to content

Commit

Permalink
fix!: Remove browser field from package.json (#2255)
Browse files Browse the repository at this point in the history
* fix!: Remove browser field from package.json of core packages so that worker export doesn't get mapped back to removeBrowserPackageJson

BREAKING CHANGE: Jest was previously mentioned as the reason that wasn't removed, but Jest now supports package.json modules. That said, some other tooling might still not support esm exports.

* Create rare-birds-train.md

---------

Co-authored-by: Ryan Carniato <[email protected]>
  • Loading branch information
wkelly17 and ryansolid authored Sep 23, 2024
1 parent 2a3a198 commit 120bf06
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 12 deletions.
5 changes: 5 additions & 0 deletions .changeset/rare-birds-train.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"solid-js": minor
---

fix!: Remove browser field from package.json
4 changes: 0 additions & 4 deletions packages/solid/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@
},
"main": "./dist/server.cjs",
"module": "./dist/server.js",
"browser": {
"./dist/server.cjs": "./dist/solid.cjs",
"./dist/server.js": "./dist/solid.js"
},
"unpkg": "./dist/solid.cjs",
"types": "types/index.d.ts",
"sideEffects": false,
Expand Down
4 changes: 0 additions & 4 deletions packages/solid/store/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@
"name": "solid-js/store",
"main": "./dist/server.cjs",
"module": "./dist/server.js",
"browser": {
"./dist/server.cjs": "./dist/store.cjs",
"./dist/server.js": "./dist/store.js"
},
"unpkg": "./dist/store.cjs",
"types": "./types/index.d.ts",
"type": "module",
Expand Down
4 changes: 0 additions & 4 deletions packages/solid/web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@
"name": "solid-js/web",
"main": "./dist/server.cjs",
"module": "./dist/server.js",
"browser": {
"./dist/server.cjs": "./dist/web.cjs",
"./dist/server.js": "./dist/web.js"
},
"unpkg": "./dist/web.cjs",
"types": "./types/index.d.ts",
"type": "module",
Expand Down

0 comments on commit 120bf06

Please sign in to comment.