-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possible semaphore mechanism wording #324
base: feature/sparql-update
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be "if" or "when"? (I know sparq11-update says 'if' but context may be a bit different here.) Trying to first get a sense of where you want to go with this.
Didn't make this change but would consider whether the language should be closer to "abort the sequence of operations, causing the subsequent operations to be ignored" instead of "any modification".
Changed to sparql11-update reference as that's the specific spec being referred to.
server-patch-sparql-outside-subset
is already in use. Changed to server-patch-sparql-abort
for now -- not sure if that's specific enough.
Co-authored-by: Sarven Capadisli <[email protected]>
Yes, I couldn't see the practical difference, and so I chose to align with the terms that was used in most of the sentence.
As explained in #322 , this is a different thing, that applies when the request contains several operations, in this case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized this is not going to work, because NSS rejects even if there are no variables: #322 (comment)
Whereas I personally think that this NSS behavior is the wrong behavior for Solid, it does mean that this PR does not achieve our goal.
I'm proposing a draft of the wording I proposed in #322. I think this is the minimal change we can do to SPARQL that also legitimizes the behaviour in NSS with regards to the semaphore mechanism.