Improvements learned from CSS #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michielbdejong
commented
Feb 10, 2021
test/helpers/env.ts
Outdated
| @@ -8,6 +8,6 @@ export function generateTestFolder() { | |||
| const testFolder = `solid-crud-tests-${new Date().getTime()}`; | |||
| return { | |||
| testFolder, | |||
| testFolderUrl: `${storageRoot}/${testFolder}/`, | |||
| testFolderUrl: `${storageRoot}${testFolder}/`, | |||
There was a problem hiding this comment.
ah wait, let me revert that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the Solid CRUD tests against Ruben's CSS server opened our eyes to some room for improvement. This branch has a number of improvements to the tests, that make version 0.7 of CSS pass 52/52 tests. I skipped 9 tests because either they need work or (in case of the string-literal conneg tests), maybe those tests were a bad idea all along.