Docs update and other minor fixes #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- projectserum.com RPC endpoint is no more so example in docs was failing. Make a single constant for RPC URL, explain what it is, and what values could be. - Minor docs tweaks (first time I ran this, I wasn't actually sure what UTR LTL or CG stood for - it's obvious in retrospect but not for newcomers) - Use async/await for FS operations - Use 2-space JS just for README (I know you use 4 for your code, but README is going to be viewed by people who write JS generally and 2-spaces is the default almost everywhere, I hope that's OK)
skakac
approved these changes
Jan 23, 2023
|
PS here's a PR if you just want Apache 2 like Solana, Rust, and SPL. #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making this! Was speaking to Jacob and he mentioned this URL Aggregator is the best source of tokens in Sol right now, so thought I'd send you a PR.