-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NH-89194: upgrade to upstream 2.8.0 #262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, would be good to confirm the upstream improvement for lambda instrumentation with our layer!
@cheempz Any specific item you're thinking of? |
68f5096
to
63499dc
Compare
I'm thinking some checks specifically around a function with the RequestStreamHandler interface, where our layer should reflect the upstream fix... hmm and maybe that a function with RequestHandler interface still works as expected, no regression. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
It looks like there isn't any changes affecting those components in the release? |
i was looking at open-telemetry/opentelemetry-java-instrumentation#11868 which is part of the upstream 2.7.0 release, it seems to have changed the lambda instrumentation. |
Gotcha. It looks like that only affects users that implement those abstract classes instead of the vanilla lambda ones or uses the wrapper for loading their code. |
|
Upgrades to upstream
2.8.0
.