NH-87394: ensure url is formed when port is appended #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheempz
reviewed
Jul 29, 2024
|
|
||
| assertNotNull(System.getProperty("otel.exporter.otlp.logs.endpoint")); | ||
| assertDoesNotThrow(() -> new URL(System.getProperty("otel.exporter.otlp.logs.endpoint"))); | ||
| } |
There was a problem hiding this comment.
Great to have this test! To confirm, if the customer is pointing to AO but somehow enables log export, does our distro still try to automatically set any of the OTel log export system properties? Wondering if the log export setting should just take no effect in this scenario, i.e. the customer would need to manually set all the OTel config needed to export logs to SWO.
cheempz
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer experienced startup error with our latest release
2.5.0; this occurred because the code didn't consider that the collector endpoint can be specified with the port number. This code change addresses this scenario and adds unit test to cover this scenario. We'll not attempt to setup the configuration when the collector endpoint isappoptics.com.Test services 0, 1 and 2