Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-86983: make otel log export opt-in only #246

Merged
merged 1 commit into from
Jul 24, 2024
Merged

NH-86983: make otel log export opt-in only #246

merged 1 commit into from
Jul 24, 2024

Conversation

cleverchuk
Copy link
Contributor

We're making otel log export opt-in only and also updated the test to reflect the current state of things. Now user must explicitly set SW_APM_EXPORT_LOGS_ENABLED or its other equivalents to true to get this feature enabled.

To check tabs on data generated by tests use below links
Test services 0, 1 and 2

@cleverchuk cleverchuk requested a review from a team as a code owner July 24, 2024 17:53
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cleverchuk cleverchuk merged commit 27d2df3 into main Jul 24, 2024
11 checks passed
@cleverchuk cleverchuk deleted the cc/NH-86983 branch July 24, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants