Merge pull request #18 from appoptics/NH-5044-profiling-processor-npe

NH-5044: Print stacktrace for OboeException
solarwinds · Nov 30, 2021 · d24537b · d24537b
2 parents 2575be9 + 5bfeda8
commit d24537b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/core-bootstrap/src/main/java/com/appoptics/opentelemetry/core/Util.java b/core-bootstrap/src/main/java/com/appoptics/opentelemetry/core/Util.java
@@ -60,7 +60,8 @@ public static Metadata buildMetadata(SpanContext context) {
         try {
             return new Metadata(W3CContextToHexString(context));
         } catch (OboeException e) {
-            return null;
+            logger.info("Failed to get AO metadata from span context: " + W3CContextToHexString(context), e);
+            return new Metadata();
         }
     }
 

diff --git a/...src/main/java/com/appoptics/opentelemetry/extensions/AppOpticsProfilingSpanProcessor.java b/...src/main/java/com/appoptics/opentelemetry/extensions/AppOpticsProfilingSpanProcessor.java
@@ -35,8 +35,10 @@ public void onStart(Context parentContext, ReadWriteSpan span) {
             if (!parentSpanContext.isValid() || parentSpanContext.isRemote()) { //then a root span of this service
                 if (PROFILER_ENABLED) {
                     Metadata metadata = Util.buildMetadata(span.getSpanContext());
-                    Profiler.addProfiledThread(Thread.currentThread(), metadata, metadata.getTraceId());
-                    span.setAttribute(SW_KEY_PREFIX + "ProfileSpans", 1);
+                    if (metadata.isValid()) {
+                        Profiler.addProfiledThread(Thread.currentThread(), metadata, metadata.getTraceId());
+                        span.setAttribute(SW_KEY_PREFIX + "ProfileSpans", 1);
+                    }
                 } else {
                     span.setAttribute(SW_KEY_PREFIX + "ProfileSpans", -1); //profiler disabled
                 }