NH-94685: name change for span stacktrace stuff

solarwinds · Dec 24, 2024 · 02e9da6 · 02e9da6
1 parent ea4a933
commit 02e9da6
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 9 deletions.
diff --git a/build.gradle b/build.gradle
@@ -50,7 +50,7 @@ subprojects {
                 opentelemetryJavaagent: property('otel.agent.version'),
                 bytebuddy             : "1.15.10",
                 guava                 : "30.1-jre",
-                joboe                 : "10.0.16",
+                joboe                 : "10.0.17",
                 agent                 : swoVersion, // the custom distro agent version
                 autoservice           : "1.0.1",
                 caffeine              : "2.9.3",

diff --git a/...mbda/src/main/java/com/solarwinds/opentelemetry/extensions/LambdaConfigurationLoader.java b/...mbda/src/main/java/com/solarwinds/opentelemetry/extensions/LambdaConfigurationLoader.java
@@ -64,7 +64,7 @@ public class LambdaConfigurationLoader {
     ConfigProperty.AGENT_TRIGGER_TRACE_ENABLED.setParser(ModeStringToBooleanParser.INSTANCE);
     ConfigProperty.AGENT_TRANSACTION_NAMING_SCHEMES.setParser(new TransactionNamingSchemesParser());
     ConfigProperty.AGENT_SQL_TAG_DATABASES.setParser(new SqlTagDatabasesParser());
-    ConfigProperty.AGENT_SPAN_STACK_TRACE_FILTERS.setParser(new StackTraceFilterParser());
+    ConfigProperty.AGENT_SPAN_STACKTRACE_FILTERS.setParser(new StacktraceFilterParser());
   }
 
   public static void load() throws InvalidConfigException {

diff --git a/...om/shared/src/main/java/com/solarwinds/opentelemetry/extensions/SpanStacktraceFilter.java b/...om/shared/src/main/java/com/solarwinds/opentelemetry/extensions/SpanStacktraceFilter.java
@@ -32,7 +32,7 @@ public class SpanStacktraceFilter implements Predicate<ReadableSpan> {
     filterAttributes.add("db.system");
     Set<String> configuredFilterAttributes =
         ConfigManager.getConfigOptional(
-            ConfigProperty.AGENT_SPAN_STACK_TRACE_FILTERS, filterAttributes);
+            ConfigProperty.AGENT_SPAN_STACKTRACE_FILTERS, filterAttributes);
     filterAttributes.addAll(configuredFilterAttributes);
   }
 

diff --git a/...ry/extensions/StackTraceFilterParser.java → ...ry/extensions/StacktraceFilterParser.java b/...ry/extensions/StackTraceFilterParser.java → ...ry/extensions/StacktraceFilterParser.java
@@ -27,7 +27,7 @@
 import java.util.Set;
 import java.util.stream.Collectors;
 
-public final class StackTraceFilterParser implements ConfigParser<String, Set<String>> {
+public final class StacktraceFilterParser implements ConfigParser<String, Set<String>> {
   private static final Gson gson = new GsonBuilder().create();
 
   @Override

diff --git a/...xtensions/StackTraceFilterParserTest.java → ...xtensions/StacktraceFilterParserTest.java b/...xtensions/StackTraceFilterParserTest.java → ...xtensions/StacktraceFilterParserTest.java
@@ -27,9 +27,9 @@
 import org.mockito.junit.jupiter.MockitoExtension;
 
 @ExtendWith(MockitoExtension.class)
-class StackTraceFilterParserTest {
+class StacktraceFilterParserTest {
 
-  @InjectMocks private StackTraceFilterParser tested;
+  @InjectMocks private StacktraceFilterParser tested;
 
   @Test
   void returnListOfStringGivenCommaSeparatedString() throws InvalidConfigException {

diff --git a/...src/main/java/com/solarwinds/opentelemetry/extensions/initialize/ConfigurationLoader.java b/...src/main/java/com/solarwinds/opentelemetry/extensions/initialize/ConfigurationLoader.java
@@ -42,7 +42,7 @@
 import com.solarwinds.opentelemetry.extensions.NamingScheme;
 import com.solarwinds.opentelemetry.extensions.RangeValidationParser;
 import com.solarwinds.opentelemetry.extensions.SqlTagDatabasesParser;
-import com.solarwinds.opentelemetry.extensions.StackTraceFilterParser;
+import com.solarwinds.opentelemetry.extensions.StacktraceFilterParser;
 import com.solarwinds.opentelemetry.extensions.TracingModeParser;
 import com.solarwinds.opentelemetry.extensions.TransactionNameManager;
 import com.solarwinds.opentelemetry.extensions.TransactionNamingScheme;
@@ -102,7 +102,7 @@ public class ConfigurationLoader {
     ConfigProperty.PROFILER.setParser(ProfilerSettingParser.INSTANCE);
     ConfigProperty.AGENT_TRANSACTION_NAMING_SCHEMES.setParser(new TransactionNamingSchemesParser());
     ConfigProperty.AGENT_SQL_TAG_DATABASES.setParser(new SqlTagDatabasesParser());
-    ConfigProperty.AGENT_SPAN_STACK_TRACE_FILTERS.setParser(new StackTraceFilterParser());
+    ConfigProperty.AGENT_SPAN_STACKTRACE_FILTERS.setParser(new StacktraceFilterParser());
   }
 
   public static void load() throws InvalidConfigException {

diff --git a/smoke-tests/src/test/java/com/solarwinds/agents/Agent.java b/smoke-tests/src/test/java/com/solarwinds/agents/Agent.java
@@ -42,7 +42,7 @@ public Agent(String name, String description) {
   public Agent(String name, String description, String url) {
     this(name, description, url, Arrays.asList("-Dio.opentelemetry.context.enableStrictContext=true",
             "-Dotel.java.experimental.span-stacktrace.min.duration=0ms",
-            "-Dsw.apm.span.stack.trace.filters=thread.id,os.description,http.request.method"));
+            "-Dsw.apm.span.stacktrace.filters=thread.id,os.description,http.request.method"));
   }
 
   public Agent(String name, String description, String url, List<String> additionalJvmArgs) {