Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NH-78291] Lambda support #106

Merged
merged 42 commits into from
Jul 22, 2024
Merged

[NH-78291] Lambda support #106

merged 42 commits into from
Jul 22, 2024

Conversation

swi-jared
Copy link
Contributor

@swi-jared swi-jared commented Jun 28, 2024

Before merge

  • point lambda instrumentation at 1.1.0

@swi-jared swi-jared changed the title [WIP] Lambda support [NH-78291] Lambda support Jul 9, 2024
@swi-jared swi-jared marked this pull request as ready for review July 9, 2024 18:05
@swi-jared swi-jared requested a review from a team as a code owner July 9, 2024 18:05

require (
github.com/aws/aws-lambda-go v1.47.0
// TODO this has to be updated to a version that actually has support for Lambda
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merge: point this at 1.1.0 and tag after merge

Copy link
Member

@raphael-theriault-swi raphael-theriault-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me, but had a few comments and questions

internal/entryspans/entryspans.go Show resolved Hide resolved
internal/oboe/settings_lambda.go Show resolved Hide resolved
Copy link
Member

@raphael-theriault-swi raphael-theriault-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything I could think of has been addressed now, thanks !

@swi-jared swi-jared merged commit c2d9ae3 into main Jul 22, 2024
7 checks passed
@swi-jared swi-jared deleted the lambda branch July 22, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants