The online/offline checker now presumes that globalThis is the event target
#3658
+11
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a66d51b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
BundleMonUnchanged files (125)
Total files change -12B 0% Final result: ✅ View report in BundleMon website ➡️ |
steveluscher
force-pushed
the
12-02-the_online_offline_checker_now_presumes_that_globalthis_is_the_event_target
branch
from
78a9f6f
to
a66d51b
Compare
|
A preview of the GitHub Pages site based on this PR is now available here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the isolated Content Scripts environment,
globalThis.windowis apparently not a thing. In this PR we eliminate that nesting and presume that the event target for listening to online/offline events isglobalThisitself.Test Plan
Tested that
globalThis.addEventListener('offline', () => {})fires the callback in Brave when the network connection goes down. Presumed that the same is true for all other browsers.Fixes #3652.