-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor for ControllerGroup + synchronized #73
Open
GoToLoop
wants to merge
13
commits into
sojamo:master
Choose a base branch
from
GoToLoop:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jul 6, 2016
-
Refactor for ControllerGroup + synchronized
* I wasn't expecting almost 1000 lines of code, but I've taken the challenge anyways. * Placed localized `synchronized ()` not only for those 2 _**Vector**_ containers from _controllers_ field, but also for the 2 __*ArrayList*__ in __*ControllerGroup*__ class. * Mostly for all sections doing iteration on them, but also when their **size()** changes. * Prepended `@Override` for all inherited methods in __*ControllerGroup*__ class. * Prepended `final` for all fields which didn't seem they would be re-assigned. * Lotsa further cleanups I can't remember I did. :P
Configuration menu - View commit details
-
Copy full SHA for d30c234 - Browse repository at this point
Copy the full SHA d30c234View commit details
Commits on Jul 9, 2016
-
Since __*ArrayList*__ isn't safe like __*Vector*__, I'm also adding `synchronized ()` at places where either of its structure's **size()** changes. Those 6 methods are: **add()**, **addDrawable()**, **remove()**, **removeDrawable()**, **clear()** and **clearDrawable()**. Of course, all loops traversing this class still needs to be synchronized externally as well; either over **get()** or **getDrawables()**. Last word: This patch is just a standalone performant refactoring. It's not obligatory for __*ControllerGroup*__'s previous patch.
Configuration menu - View commit details
-
Copy full SHA for d9af4c2 - Browse repository at this point
Copy the full SHA d9af4c2View commit details -
Merge pull request #1 from GoToLoop/ControllerList-patch-1
Change Vector to ArrayList
Configuration menu - View commit details
-
Copy full SHA for 2a15aaa - Browse repository at this point
Copy the full SHA 2a15aaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 669b71b - Browse repository at this point
Copy the full SHA 669b71bView commit details -
Merge pull request #2 from GoToLoop/revert-1-ControllerList-patch-1
Revert "Change Vector to ArrayList"
Configuration menu - View commit details
-
Copy full SHA for 1ed2209 - Browse repository at this point
Copy the full SHA 1ed2209View commit details -
Configuration menu - View commit details
-
Copy full SHA for 27371a5 - Browse repository at this point
Copy the full SHA 27371a5View commit details
Commits on Jul 10, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 18e95d9 - Browse repository at this point
Copy the full SHA 18e95d9View commit details
Commits on Jul 11, 2016
-
ControllerGroup< ? extends ControllerGroup< ? > >
Configuration menu - View commit details
-
Copy full SHA for 0f3f381 - Browse repository at this point
Copy the full SHA 0f3f381View commit details
Commits on Jul 15, 2016
-
Initialize _**String**_ fields w/ an empty `""`.
Configuration menu - View commit details
-
Copy full SHA for 84b0940 - Browse repository at this point
Copy the full SHA 84b0940View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ad8ff1 - Browse repository at this point
Copy the full SHA 8ad8ff1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1085e4 - Browse repository at this point
Copy the full SHA b1085e4View commit details
Commits on Jul 16, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 310d9e2 - Browse repository at this point
Copy the full SHA 310d9e2View commit details
Commits on Jul 17, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 50e1264 - Browse repository at this point
Copy the full SHA 50e1264View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.