Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for ControllerGroup + synchronized #73

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Commits on Jul 6, 2016

  1. Refactor for ControllerGroup + synchronized

    * I wasn't expecting almost 1000 lines of code, but I've taken the challenge anyways.
    * Placed localized `synchronized ()` not only for those 2 _**Vector**_ containers from _controllers_ field, but also for the 2 __*ArrayList*__ in __*ControllerGroup*__ class.
    * Mostly for all sections doing iteration on them, but also when their **size()** changes.
    * Prepended `@Override` for all inherited methods in __*ControllerGroup*__ class.
    * Prepended `final` for all fields which didn't seem they would be re-assigned.
    * Lotsa further cleanups I can't remember I did.  :P
    GoToLoop authored Jul 6, 2016
    Configuration menu
    Copy the full SHA
    d30c234 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2016

  1. Change Vector to ArrayList

    Since __*ArrayList*__ isn't safe like __*Vector*__, I'm also adding `synchronized ()` at places where either of its structure's **size()** changes.
    Those 6 methods are: **add()**, **addDrawable()**, **remove()**, **removeDrawable()**, **clear()** and **clearDrawable()**.
    Of course, all loops traversing this class still needs to be synchronized externally as well; either over **get()** or **getDrawables()**.
    Last word: This patch is just a standalone performant refactoring. It's not obligatory for __*ControllerGroup*__'s previous patch.
    GoToLoop authored Jul 9, 2016
    Configuration menu
    Copy the full SHA
    d9af4c2 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1 from GoToLoop/ControllerList-patch-1

    Change Vector to ArrayList
    GoToLoop authored Jul 9, 2016
    Configuration menu
    Copy the full SHA
    2a15aaa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    669b71b View commit details
    Browse the repository at this point in the history
  4. Merge pull request #2 from GoToLoop/revert-1-ControllerList-patch-1

    Revert "Change Vector to ArrayList"
    GoToLoop authored Jul 9, 2016
    Configuration menu
    Copy the full SHA
    1ed2209 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    27371a5 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2016

  1. Update ControllerGroup.java

    GoToLoop authored Jul 10, 2016
    Configuration menu
    Copy the full SHA
    18e95d9 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2016

  1. Update ControllerGroup.java

    ControllerGroup< ? extends ControllerGroup< ? > >
    GoToLoop authored Jul 11, 2016
    Configuration menu
    Copy the full SHA
    0f3f381 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2016

  1. Update ControllerGroup.java

    Initialize _**String**_ fields w/ an empty `""`.
    GoToLoop authored Jul 15, 2016
    Configuration menu
    Copy the full SHA
    84b0940 View commit details
    Browse the repository at this point in the history
  2. Update ControllerGroup.java

    GoToLoop authored Jul 15, 2016
    Configuration menu
    Copy the full SHA
    8ad8ff1 View commit details
    Browse the repository at this point in the history
  3. Update ControllerGroup.java

    cp5
    GoToLoop authored Jul 15, 2016
    Configuration menu
    Copy the full SHA
    b1085e4 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2016

  1. Update ControllerGroup.java

    `float[]` to `float...`.
    GoToLoop authored Jul 16, 2016
    Configuration menu
    Copy the full SHA
    310d9e2 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2016

  1. Update ControllerGroup.java

    GoToLoop authored Jul 17, 2016
    Configuration menu
    Copy the full SHA
    50e1264 View commit details
    Browse the repository at this point in the history