Fix poller memleak when malloc failed. (#1661)

sogou · Nov 24, 2024 · 05168d9 · 05168d9
1 parent dd95599
commit 05168d9
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/src/kernel/poller.c b/src/kernel/poller.c
@@ -1332,17 +1332,20 @@ static struct __poller_node *__poller_new_node(const struct poller_data *data,
 	}
 
 	node = (struct __poller_node *)malloc(sizeof (struct __poller_node));
-	if (node)
+	if (!node)
 	{
-		node->data = *data;
-		node->event = event;
-		node->in_rbtree = 0;
-		node->removed = 0;
-		node->res = res;
-		if (timeout >= 0)
-			__poller_node_set_timeout(timeout, node);
+		free(res);
+		return NULL;
 	}
 
+	node->data = *data;
+	node->event = event;
+	node->in_rbtree = 0;
+	node->removed = 0;
+	node->res = res;
+	if (timeout >= 0)
+		__poller_node_set_timeout(timeout, node);
+
 	return node;
 }