fix: remove workaround for removing clipped subviews #2596
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the workaround introduced in series of PRs (listed chronologically here):
For detailed description of error mechanism and broader discussion please refer to:
tldr: When popping screen on Fabric we marked the views as "transitioning" and this led to view being effectively miscounted
during removal by view groups that supported react-native's subview clipping mechanism.
The issue has been present most likely in every version of the library when running on Android & Fabric, but it arose few months ago due to broader
adoption of the new architecture.
facebook/react-native#47634 is supposed to fix the underlying issue in
react-native's
core.Changes
Removed the workaround code from
Screen
implementation on Android.The
has been released with 0.77.0-rc.3 and followup small fixup:
has been released with 0.77.0-rc.4.
Therefore, with landing this PR we should limit our support on Fabric to 0.77.0.
Test code and steps to reproduce
Test2282
- note that there are few testing variants available there, you just need to comment (out) some parts of the code.Checklist