feature: wait for queued runs and an option to refresh runs from GitHub API #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any timeline on a merge? |
A positive value can be specified as value to this parameter to instruct this action to wait and poll the GitHub API if no in_progress runs are returned in the first attempt.
Refetch runs from GitHub API, If no runs are found in the first attempt and initialWaitSeconds is specified
currently queued runs are not being picked up, which is causing issues when multiple runs are queued concurrently.
1. initial-wait-seconds input parameter 2. fetch both queued and in_progress runs
vigneshmsft
force-pushed
the
initial-wait-seconds
branch
from
dc1513e
to
fbffc68
Compare
|
|
|
Any updates on getting this one merged? |
chenrui333
approved these changes
Jun 19, 2024
chenrui333
changed the title
chenrui333
force-pushed
the
initial-wait-seconds
branch
from
c7cc656
to
1086c65
Compare
Signed-off-by: Rui Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋🏽
This PR adds support to consider
queuedruns in addition toin_progresswhen checking against a list of current runs.Problem
When a run is first created in GitHub Actions, the status will be
queuedbefore moving toin_progressWhen two runs are triggered within quick succession,
there is a chance that both the runs are
queuedwith only millisecond difference and when this actionfrom within the second run tries to fetch a list of
in_progressruns (where id < itself), the list can be empty because the previous run hasn't still progressed toin_progressin the API results.We have seen this behaviour multiple times in our workflows.
Change Proposed
queuedandin_progressrunsThis would allow the second run to see that a previous run has been queued and it should wait for it to complete.
initial-wait-secondsinput parameterThis adds an option to fetch (again) the list of runs from the GitHub API, if no results are returned during the first poll.
Thanks
rebased: 13-Apr-2021