Allow Stdin to be used as input file for lrlex/nimbleparse #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratmice
commented
Aug 22, 2024
| @@ -26,14 +26,18 @@ fn usage(prog: &str, msg: &str) { | |||
| } | |||
|
|
|||
| fn read_file(path: &str) -> String { | |||
There was a problem hiding this comment.
It might be worth noting here, that the read_file functions between lrlex and nimbleparse,
seem to have diverged in their argument types:
lrlex takes an &str, which nimbleparse takes an AsRef<Path>, and the difference effects these two implementations because there is no Path* implementation for PartialEq<&str>.
This explains why in lrlex I implemented the logic inside read_file, while in nimbleparse the logic ended up outside.
There was a problem hiding this comment.
I'd be happy to see the two homogenised in a future PR!
|
Thanks -- this is good! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Sorry, looks like I failed to rustfmt |
|
Please squash. |
|
Squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working a small project where I wanted to run lrlex over some compressed data, it seemed like it would be nice
to do so without having to decompress using a temporary file... This implements it so you can do the the following
Or a nimbleparse example that should work in the repository (echo -n to avoid newline)