-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated version of documentation #449
Updated version of documentation #449
Conversation
# Conflicts: # bindings/Sofa/src/SofaPython3/Sofa/Core/Binding_Node_doc.h # bindings/Sofa/src/SofaPython3/Sofa/Core/Submodule_Core.cpp # docs/sphinx/source/content/modules/SofaExporter/index.rst
# Conflicts: # Plugin/src/SofaPython3/Prefab.cpp # bindings/Sofa/src/SofaPython3/Sofa/Core/Binding_BaseMeshTopology.cpp # bindings/Sofa/src/SofaPython3/Sofa/Core/Binding_ObjectFactory_doc.h # bindings/Sofa/src/SofaPython3/Sofa/Core/Binding_Topology.cpp # bindings/Sofa/src/SofaPython3/Sofa/Simulation/Submodule_Simulation.cpp
08fdc35
to
8d82fba
Compare
This PR should be rebased |
I'm so happy to rebase branch dating back from years. |
@hugtalbot it is rebased and tests are passing |
.github/workflows/build_docs.yml
Outdated
- created | ||
- edited | ||
workflow_dispatch: # This allows manual triggering | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so cool thanks a lot @damienmarchal for the action ❤️
Have you tested on your branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't even remember having writing that :)
So no idea how I can trigger le build_doc stuff :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@damienmarchal Since the entire PR is fine and the GitHub action should be assessed, we would suggest to remove the action from the PR and merge. It would allow to test the action separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done :)
Co-authored-by: Hugo <[email protected]>
Co-authored-by: Hugo <[email protected]>
os: "ubuntu-22.04" | ||
commands: | ||
- mkdir --parents $READTHEDOCS_OUTPUT/html/ | ||
- wget https://github.com/sofa-framework/SofaPython3/releases/download/release-v23.06/SofaPython3_v23.06_docs.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v23.06?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the doc was done at that time and as we have to manually update things I would prefer to first merge something that works then update the build process to remove the manual parts.
Fix the documentation to make the sphinx documentation generation works.