Skip to content

Commit

Permalink
CI: remove duplicate jobs, improve comments
Browse files Browse the repository at this point in the history
  • Loading branch information
sodabrew committed Dec 27, 2024
1 parent 3e88cb7 commit 8242dca
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ jobs:
strategy:
matrix:
include:
# Ruby 3.x on Ubuntu 22.04 LTS (latest at this time)
# Ruby 3.x on Ubuntu 24.04 LTS
- {os: ubuntu-24.04, ruby: 'head', db: mysql84}
- {os: ubuntu-24.04, ruby: '3.4', db: mysql84}

# Ruby 3.x on Ubuntu 22.04 LTS (latest at this time)
# Ruby 3.x on Ubuntu 22.04 LTS
- {os: ubuntu-22.04, ruby: '3.4', db: mysql80}
- {os: ubuntu-22.04, ruby: '3.3', db: mysql80}
- {os: ubuntu-22.04, ruby: '3.2', db: mysql80}
Expand All @@ -30,6 +30,10 @@ jobs:
- {os: ubuntu-20.04, ruby: '2.1', db: mysql80}
- {os: ubuntu-20.04, ruby: '2.0', db: mysql80}

# MySQL 5.7 packages stopped after Ubuntu 18.04 Bionic
# - {os: ubuntu-18.04, ruby: '2.7', db: mysql57}

# MariaDB LTS versions
# db: on Linux, ci/setup.sh installs the specified packages
# db: on MacOS, installs a Homebrew package use "[email protected]" to specify a version

Expand All @@ -38,10 +42,6 @@ jobs:
- {os: ubuntu-22.04, ruby: '2.7', db: mariadb10.11}
- {os: ubuntu-22.04, ruby: '3.0', db: mariadb10.6}
- {os: ubuntu-20.04, ruby: '2.7', db: mariadb10.6}
- {os: ubuntu-20.04, ruby: '2.7', db: mysql80}

# MySQL 5.7 packages stopped after Ubuntu 18.04 Bionic
# - {os: ubuntu-18.04, ruby: '2.7', db: mysql57}

# TODO - Windows CI
# - {os: windows-2022, ruby: '3.2', db: mysql80}
Expand All @@ -52,6 +52,7 @@ jobs:
- {os: macos-latest, ruby: '3.4', db: [email protected], ssl: openssl@3, allow-failure: true}
- {os: macos-latest, ruby: '3.4', db: [email protected], ssl: openssl@3, allow-failure: true}
- {os: macos-latest, ruby: '2.6', db: [email protected], ssl: [email protected], allow-failure: true}

# On the fail-fast: true, it cancels all in-progress jobs
# if any matrix job fails, which we don't want.
fail-fast: false
Expand Down

0 comments on commit 8242dca

Please sign in to comment.