Readme, python2 support #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
socketpair
reviewed
May 12, 2018
| try: | ||
| b = a = time.monotonic() | ||
| except (AttributeError): | ||
| import monotonic |
There was a problem hiding this comment.
Ну это капец. при каждом бенче делать импорт.
socketpair
reviewed
May 12, 2018
| import json | ||
| import argparse | ||
| import logging | ||
| import os | ||
| import time | ||
| import rados | ||
| import configparser |
There was a problem hiding this comment.
Ну ведь не тестировал же. во втором питоне конфигпасер подругому называется.
В общем, про питон2 я уже пофиксил. про индентацию и пробелы по пеп8 -- пофикшу сам попозже.
socketpair
reviewed
May 12, 2018
| # Install pre-requrements | ||
|
|
||
| ### CentOS | ||
| `yum install python-configparser python-monotonic` |
There was a problem hiding this comment.
))) он во втором питоне есть искаропки, просто подругому называется. в итоге я зарефакторил так что выпилил его использование совсем. И да, напиши для каких версий центоса это. равно как и убунту.
socketpair
reviewed
May 12, 2018
| cd ceph-bench | ||
| ceph auth export client.admin -o keyring.conf | ||
| ceph osd pool set single size 1 | ||
| ceph osd pool create single 1 1 |
There was a problem hiding this comment.
сначала креате, потом сет сайз.
и креате нифига не 1 1, а 128 128 или сколько там нужно.
|
За работу спасибо, но нужны правки. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readme, python2 support