Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade libraries to support Java 21 #59

Merged
merged 5 commits into from
Nov 17, 2023

Conversation

RoqueIT
Copy link
Contributor

@RoqueIT RoqueIT commented Oct 23, 2023

Upgrade libraries to support Java 21

@RoqueIT RoqueIT changed the title Uprade lib for java 21 Upgrade libraries to support Java 21 Oct 23, 2023
@vincent-fuchs vincent-fuchs merged commit 9a7cf6e into societe-generale:master Nov 17, 2023
2 checks passed
@vincent-fuchs
Copy link
Collaborator

available in 4.0.0 , please give it a try !

@guerrillalg
Copy link

Apparently, this broke the compatibility with Java17 and others pre 21 versions. Now this jar file is only usable with java 21 and up.

@vincent-fuchs
Copy link
Collaborator

vincent-fuchs commented Nov 23, 2023

yes, I am not surprised.

but yeah, your PR (#60 ) is only there, and not in the 3.x version.. I will cherry pick it

@guerrillalg
Copy link

Thanks for cherry-picking it!
Do you have some plans on how to support different java versions? Like 3.* for java 11-20 and 4.* for java 21+ ? Or maybe you would include java version into the classifier of the artifact, so that we can explicitly choose which one to use?

@vincent-fuchs
Copy link
Collaborator

@guerrillalg : it is now available in https://github.com/societe-generale/arch-unit-maven-plugin/releases/tag/archUnit_maven_plugin_3.0.1

there's no plan for extra support for 3.x . only the strict minimum, but anyway, we don't expect major new features, so it should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants