Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jakarta validation in model domain #86

Conversation

SofianeBelk
Copy link
Contributor

@SofianeBelk SofianeBelk commented Jan 5, 2024

Summary

This merge request aims to incorporate Jakarta validation into the model domain.

Details

The primary modification involves adding the usage of Jakarta annotations in the model. This transition ensures that the codebase aligns with current practices and utilizes the latest Jakarta technologies.

Context

With the deprecation of JavaX, Jakarta has become the recommended choice for annotations in the project. By integrating Jakarta validation into the model domain, we enhance the codebase's compatibility with contemporary standards and promote the use of up-to-date technologies.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (423c571) 79.96% compared to head (989ce22) 79.96%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #86   +/-   ##
=========================================
  Coverage     79.96%   79.96%           
  Complexity      145      145           
=========================================
  Files            33       33           
  Lines           654      654           
  Branches         65       65           
=========================================
  Hits            523      523           
  Misses          104      104           
  Partials         27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincent-fuchs vincent-fuchs merged commit c3bdbe4 into societe-generale:master Jan 6, 2024
2 checks passed
@vincent-fuchs
Copy link
Collaborator

thanks a lot for your contribution !

vincent-fuchs pushed a commit that referenced this pull request Jan 29, 2024
* Add jakarta validation in model domain

* add jakarta annotation

---------

Co-authored-by: sbelkhir <[email protected]>
(cherry picked from commit c3bdbe4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants