Skip to content
This repository has been archived by the owner on Dec 5, 2021. It is now read-only.

Core: allow re-connecting from same TelegramClient #937

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

knocte
Copy link
Collaborator

@knocte knocte commented Apr 10, 2020

If the connection dropped, there was no way to reconnect from the same
instance of TelegramClient.

If the connection dropped, there was no way to reconnect from the same
instance of TelegramClient.
@knocte knocte force-pushed the wip/allowReconnect branch from 3c41b6d to f25058d Compare April 10, 2020 07:39
@solarin
Copy link
Contributor

solarin commented Apr 10, 2020

but in this way you are not changing the TcpTransport initialization in the constructor either?

@solarin
Copy link
Contributor

solarin commented Apr 10, 2020

i the TcpTransport initialization, in the constructor, should be changed since we are working on this issue and we have a chance to make it better

@knocte
Copy link
Collaborator Author

knocte commented Apr 10, 2020

but in this way you are not changing the TcpTransport initialization in the constructor either?

why change that? we create a new transport on each ConnectAsync() call, and that's it

@solarin
Copy link
Contributor

solarin commented Apr 10, 2020

but in this way you are not changing the TcpTransport initialization in the constructor either?

why change that? we create a new transport on each ConnectAsync() call, and that's it

becauese the connection inside the constructor in TcpTransport is quite terrible

anyways, now i am running your solution. let's see if it works on the long run

@solarin
Copy link
Contributor

solarin commented Apr 11, 2020

yes this seems to be working

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants