Skip to content
This repository has been archived by the owner on May 29, 2018. It is now read-only.

Fix #355: Text not readable on error in entry (fg==bg) #395

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #355: Text not readable on error in entry (fg==bg) #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Paper/gtk-3.20/gtk-dark.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2269,7 +2269,7 @@ entry {
box-shadow: none; }
spinbutton.error:not(.vertical), GeditWindow > .error.entry,
entry.error {
color: #d32f2f;
color: #ffffff;
border-color: #420e0e; }
spinbutton.error:focus:not(.vertical), GeditWindow > .error.entry:focus,
entry.error:focus {
Expand All @@ -2281,7 +2281,7 @@ entry {
background-color: #d32f2f; }
spinbutton.warning:not(.vertical), GeditWindow > .warning.entry,
entry.warning {
color: #f9ce1d;
color: #ffffff;
border-color: #614e03; }
spinbutton.warning:focus:not(.vertical), GeditWindow > .warning.entry:focus,
entry.warning:focus {
Expand Down
4 changes: 2 additions & 2 deletions Paper/gtk-3.20/gtk.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2278,7 +2278,7 @@ entry {
box-shadow: none; }
spinbutton.error:not(.vertical), GeditWindow > .error.entry,
entry.error {
color: #d32f2f;
color: #ffffff;
border-color: #d32f2f; }
spinbutton.error:focus:not(.vertical), GeditWindow > .error.entry:focus,
entry.error:focus {
Expand All @@ -2290,7 +2290,7 @@ entry {
background-color: #d32f2f; }
spinbutton.warning:not(.vertical), GeditWindow > .warning.entry,
entry.warning {
color: #f9ce1d;
color: #ffffff;
border-color: #f9ce1d; }
spinbutton.warning:focus:not(.vertical), GeditWindow > .warning.entry:focus,
entry.warning:focus {
Expand Down
7 changes: 6 additions & 1 deletion Paper/gtk-3.20/widgets/_entries.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,12 @@ entry {
@each $e_type, $e_color in (error, $error_color),
(warning, $warning_color) {
&.#{$e_type} {
color: $e_color;
// TODO consider using https://gist.github.com/jlong/f06f5843104ee10006fe for better color determination
@if (lightness($e_color) > 60) {
color: #000000;
} @else {
color: #ffffff;
}
border-color: entry_focus_border($e_color);

&:focus { @include entry(focus, $e_color); }
Expand Down