Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Signup viewmodel #94

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Test: Signup viewmodel #94

merged 2 commits into from
Dec 4, 2023

Conversation

paul2126
Copy link
Contributor

@paul2126 paul2126 commented Dec 2, 2023

PR Title: Signup viewmodel Test

Related Issue(s):

  • Auth repository test가 에러때문에 실행이 안 되어서 주석처리 했습니다

PR Description:

  • Signup viewmodel Test
Changes Included:
  • Added new feature(s)
  • Fixed identified bug(s)
  • Updated relevant documentation
Notes for Reviewer:
  • Auth repository test가 에러때문에 실행이 안 되어서 주석처리 했습니다

Reviewer Checklist:

  • Code is written in clean, maintainable, and idiomatic form.
  • Automated test coverage is adequate.
  • All existing tests pass.
  • Manual testing has been performed to ensure the PR works as expected.
  • Code review comments have been addressed or clarified.

Additional Comments:

Add any other comments or information that might be useful for the
review process.

@89645321
Copy link
Contributor

89645321 commented Dec 3, 2023

여기도 coverage가 33 75 67로 뜨는데 class coverage(33)는 신경 안 써도 될 것 같고 line coverage 높일 수 있으면 높여주시면 감사하겠습니다! 힘들면 안 해도 될 것 같긴 해요

Copy link
Contributor

@JH747 JH747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

method coverage 80 근접하니 이대로 머지하겠습니다.
고생하셨습니다.

@JH747 JH747 merged commit ce5636c into main Dec 4, 2023
1 check passed
@JH747 JH747 deleted the test/signup-viewmodel branch December 4, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants