Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Change coroutine to execute after response on login #72

Merged
merged 4 commits into from
Nov 26, 2023

Conversation

paul2126
Copy link
Contributor

@paul2126 paul2126 commented Nov 26, 2023

PR Title: Change coroutine to execute after response on login

Related Issue(s):

  • 코루틴이 동시에 여러 response를 받으면 터지는 상황을 방지하기 위해 response를 받은 다음 함수를 순차적으로 실행하도록 함
  • 로그인시 다운받은 개인이 만든 상징과 즐겨찾기 한 상징들 중 첫번째 상징만 등록되는 현상 수정

PR Description:

  • Change coroutine to execute after response on login
  • Update last update date on login
Changes Included:
  • Added new feature(s)
  • Fixed identified bug(s)
  • Updated relevant documentation
Notes for Reviewer:

Any specific instructions or points to be considered by the
reviewer.

Reviewer Checklist:

  • Code is written in clean, maintainable, and idiomatic form.
  • Automated test coverage is adequate.
  • All existing tests pass.
  • Manual testing has been performed to ensure the PR works as expected.
  • Code review comments have been addressed or clarified.

Additional Comments:

Add any other comments or information that might be useful for the
review process.

@paul2126 paul2126 added bug Something isn't working frontend Feature implementation for frontend labels Nov 26, 2023
@paul2126 paul2126 requested review from 89645321 and JH747 November 26, 2023 13:51
Copy link
Contributor

@JH747 JH747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 순차적으로 동작하도록 수정된 부분 확인하였고 첫번째 상징만 등록되는 현상도 일어나지 않는 것 확인했습니다.
고생하셨습니다.

@JH747 JH747 merged commit a58c4c4 into main Nov 26, 2023
1 check passed
@JH747 JH747 deleted the fix/receive-info-on-login branch November 26, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Feature implementation for frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants