Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multimode/play 멀티모드 화면 일부 변경 및 소켓 통신 오류 해결 #42

Merged
merged 12 commits into from
Nov 9, 2023

Conversation

Jack-Chagarr
Copy link
Contributor

@Jack-Chagarr Jack-Chagarr commented Nov 8, 2023

PR Title: [멀티모드 화면 일부 변경 및 소켓 통신 오류 해결]

Related Issue(s):

Link or reference any related issues or tickets.
MultiModeResultFragment에서 유저의 달린 거리 및 달린 시간 반영 안되는 문제 수정
MultiModePlayFragment 및 MultiModeResultFragment에서 소켓통신시 float value의 소수 값 절삭되는 문제 수정 및 소수점 통일
MultiModePlayFragment에서 경기 중 화면 꺼질 시 앱이 종료되는 오류 수정
MultiModePlayFragment에 BackgroundLocationService 반영

PR Description:

[Provide a brief summary of the changes made.]

Changes Included:
  • Added new feature(s)
  • Fixed identified bug(s)
  • Updated relevant documentation
Screenshots (if UI changes were made):

Attach screenshots or GIFs of any visual changes. (Only for
frontend-related changes)

Notes for Reviewer:

Any specific instructions or points to be considered by the
reviewer.

Reviewer Checklist:

  • Code is written in clean, maintainable, and idiomatic form.
  • Automated test coverage is adequate.
  • All existing tests pass.
  • Manual testing has been performed to ensure the PR works as
    expected.
  • Code review comments have been addressed or clarified.

Additional Comments:

Add any other comments or information that might be useful for the
review process.

Copy link
Contributor

@SNURO SNURO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect ;) 폰트만 적용해주세요

확인됨 - MultiModeResultFragment에서 유저의 달린 거리 및 달린 시간 반영 안되는 문제
확인됨 - MultiModePlayFragment 및 MultiModeResultFragment에서 소켓통신시 float value의 소수 값 절삭되는 문제
확인됨 - (앱 나가도 백그라운드에서 잘 작동)MultiModePlayFragment에서 경기 중 화면 꺼질 시 앱이 종료되는 오류 수정
확인됨 - MultiModePlayFragment에 BackgroundLocationService 반영

@SNURO SNURO merged commit 49847e3 into main Nov 9, 2023
1 check passed
@SNURO SNURO deleted the multimode/play branch November 9, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants