Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: FileLogger added, Speedlist deleted (unused), enlarged modal exit button, added dummy profile #40

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

SNURO
Copy link
Contributor

@SNURO SNURO commented Nov 8, 2023

PR Title: FileLogger added, Speedlist deleted (unused), enlarged modal exit button, added dummy profile

Related Issue(s):

앱 싱글모드 플레이 시 시간이 10분 이상 지나면 강제 종료되는 현상
room create 시 x버튼이 작아서 잘 눌리지 않고 사용성이 떨어지는 현상

PR Description:

FileLogger added to check distance on still state
Speedlist deleted due to error on long duration singlemode play (usused for now), checked history save still works well
enlarged modal exit button on multimode room create
added dummy profile

Changes Included:
  • [v ] Added new feature(s)
  • [v ] Fixed identified bug(s)
  • Updated relevant documentation
Screenshots (if UI changes were made):

Attach screenshots or GIFs of any visual changes. (Only for
frontend-related changes)

Notes for Reviewer:

Any specific instructions or points to be considered by the
reviewer.

Reviewer Checklist:

  • Code is written in clean, maintainable, and idiomatic form.
  • Automated test coverage is adequate.
  • All existing tests pass.
  • Manual testing has been performed to ensure the PR works as
    expected.
  • Code review comments have been addressed or clarified.

Additional Comments:

Add any other comments or information that might be useful for the
review process.

SNURO added 2 commits November 9, 2023 02:38
…due to error on long duration singlemode play, enlarged modal exit button on multimode room create
@SNURO SNURO changed the title FileLogger added, Speedlist deleted (unused), enlarged modal exit button Fix: FileLogger added, Speedlist deleted (unused), enlarged modal exit button, added dummy profile Nov 8, 2023
Copy link
Contributor

@Jack-Chagarr Jack-Chagarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가하신 코드 작동 확인했습니다.

@Jack-Chagarr Jack-Chagarr merged commit b1d19e6 into main Nov 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants