Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SNOW-1752915]: Fix flaky read_snowflake test #2757

Merged
merged 1 commit into from
Dec 13, 2024
Merged

[SNOW-1752915]: Fix flaky read_snowflake test #2757

merged 1 commit into from
Dec 13, 2024

Conversation

sfc-gh-rdurrani
Copy link
Contributor

@sfc-gh-rdurrani sfc-gh-rdurrani commented Dec 13, 2024 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1752915

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

Fix a flaky test involving system functions by using select (rather than call, which is incorrect and lead to flakiness).

Explanation for why the test is flaky/why this fix works: https://snowflakecomputing.atlassian.net/browse/SNOW-1752915?focusedCommentId=5988766

@sfc-gh-rdurrani sfc-gh-rdurrani requested a review from a team as a code owner December 13, 2024 00:48
@sfc-gh-rdurrani sfc-gh-rdurrani added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Dec 13, 2024
sfc-gh-helmeleegy
sfc-gh-helmeleegy reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. This has been flaky for a while!

sfc-gh-helmeleegy
sfc-gh-helmeleegy approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sfc-gh-nkrishna
sfc-gh-nkrishna approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM!

@sfc-gh-rdurrani sfc-gh-rdurrani enabled auto-merge (squash) December 13, 2024 00:56
@sfc-gh-rdurrani sfc-gh-rdurrani merged commit 48342b2 into main Dec 13, 2024
45 of 46 checks passed
@sfc-gh-rdurrani sfc-gh-rdurrani deleted the rdurrani-SNOW-1752915 branch December 13, 2024 01:22
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-helmeleegy sfc-gh-helmeleegy sfc-gh-helmeleegy approved these changes

@sfc-gh-nkrishna sfc-gh-nkrishna sfc-gh-nkrishna approved these changes

@sfc-gh-jjiao sfc-gh-jjiao Awaiting requested review from sfc-gh-jjiao sfc-gh-jjiao is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-rdurrani @sfc-gh-nkrishna @sfc-gh-helmeleegy