Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1801330: Map numpy functions in apply to builtin snowflake functions #2755

Merged
merged 2 commits into from
Dec 13, 2024
Merged

SNOW-1801330: Map numpy functions in apply to builtin snowflake functions #2755

merged 2 commits into from
Dec 13, 2024

Conversation

sfc-gh-nkumar
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1801330

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

    Map numpy functions to builtin snowpark function if exists. In POC this provided 5x speedup.

@sfc-gh-nkumar sfc-gh-nkumar requested a review from a team as a code owner December 12, 2024 21:49
@sfc-gh-nkumar sfc-gh-nkumar force-pushed the nkumar-SNOW-1801330-apply-builtin branch from 5e77256 to 0fec0ed Compare December 12, 2024 21:54
@sfc-gh-nkumar sfc-gh-nkumar added the NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs label Dec 12, 2024
@sfc-gh-nkumar sfc-gh-nkumar force-pushed the nkumar-SNOW-1801330-apply-builtin branch from 0fec0ed to 981cce0 Compare December 13, 2024 05:09
@sfc-gh-nkumar sfc-gh-nkumar force-pushed the nkumar-SNOW-1801330-apply-builtin branch from 981cce0 to 810cd76 Compare December 13, 2024 21:01
@sfc-gh-nkumar sfc-gh-nkumar merged commit b58920b into main Dec 13, 2024
42 of 43 checks passed
@sfc-gh-nkumar sfc-gh-nkumar deleted the nkumar-SNOW-1801330-apply-builtin branch December 13, 2024 22:27
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-jjiao sfc-gh-jjiao sfc-gh-jjiao approved these changes

@sfc-gh-jkew sfc-gh-jkew sfc-gh-jkew approved these changes

@sfc-gh-dpetersohn sfc-gh-dpetersohn Awaiting requested review from sfc-gh-dpetersohn sfc-gh-dpetersohn is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-helmeleegy sfc-gh-helmeleegy Awaiting requested review from sfc-gh-helmeleegy

Assignees
No one assigned
Labels
NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-nkumar @sfc-gh-jkew @sfc-gh-helmeleegy @sfc-gh-jjiao